about summary refs log tree commit diff
diff options
context:
space:
mode:
authorFlorian Klink <flokli@flokli.de>2024-04-14T13·58+0300
committerclbot <clbot@tvl.fyi>2024-04-15T19·32+0000
commit9dc621cd95d0263f66f32005501a83e0d6bf7c03 (patch)
tree9db2c31dfc78aded4eb2b0ca15464213d0427faa
parent71566970104bc99c8400c2d4920334dcd8471519 (diff)
fix(tix/castore/blobservice): don't warn if chunk list is empty r/7935
It's perfectly normal if we ask for more granular chunking info and the
backend responds it does not have it.

Change-Id: I593ab3e53b4f4e70c99f39b266546d2ac8eb10c1
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11437
Reviewed-by: Connor Brewster <cbrewster@hey.com>
Tested-by: BuildkiteCI
Autosubmit: flokli <flokli@flokli.de>
-rw-r--r--tvix/castore/src/blobservice/grpc.rs5
1 files changed, 1 insertions, 4 deletions
diff --git a/tvix/castore/src/blobservice/grpc.rs b/tvix/castore/src/blobservice/grpc.rs
index 9230abaf34..632acef158 100644
--- a/tvix/castore/src/blobservice/grpc.rs
+++ b/tvix/castore/src/blobservice/grpc.rs
@@ -13,7 +13,7 @@ use tokio_util::{
     sync::PollSender,
 };
 use tonic::{async_trait, transport::Channel, Code, Status};
-use tracing::{instrument, warn};
+use tracing::instrument;
 
 /// Connects to a (remote) tvix-store BlobService over gRPC.
 #[derive(Clone)]
@@ -161,9 +161,6 @@ impl BlobService for GRPCBlobService {
                 resp.validate()
                     .map_err(|e| std::io::Error::new(io::ErrorKind::InvalidData, e))?;
 
-                if resp.chunks.is_empty() {
-                    warn!("chunk list is empty");
-                }
                 Ok(Some(resp.chunks))
             }
         }