From 80d0b305a74885850aae5f5941d2c9fccbeaec9b Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Sun, 14 Apr 2024 17:06:43 +0300 Subject: docs(tvix/castore/blobservice): explain open_read for small blobs more State that this case applies if the blob is small enough to fit inside a single chunk. Change-Id: I0383514729e686799599b629cf1303b284147bb4 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11440 Autosubmit: flokli Tested-by: BuildkiteCI Reviewed-by: Connor Brewster --- tvix/castore/src/blobservice/object_store.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/tvix/castore/src/blobservice/object_store.rs b/tvix/castore/src/blobservice/object_store.rs index 04fb9360b4..d2d0a288a5 100644 --- a/tvix/castore/src/blobservice/object_store.rs +++ b/tvix/castore/src/blobservice/object_store.rs @@ -149,6 +149,7 @@ impl BlobService for ObjectStoreBlobService { .await { Ok(res) => { + // handle reading blobs that are small enough to fit inside a single chunk: // fetch the entire chunk into memory, decompress, ensure the b3 digest matches, // and return a io::Cursor over that data. // FUTUREWORK: use zstd::bulk to prevent decompression bombs -- cgit 1.4.1