From 60b47b336b2c1bc2d39dbe5b6360cab1cea9a5eb Mon Sep 17 00:00:00 2001 From: Florian Klink Date: Wed, 20 Mar 2024 17:22:58 +0200 Subject: refactor(tvix/castore/directory): remove GRPCPutter::new This is no public API to construct this, there's exactly one caller, and it's perfectly fine to directly populate the struct there. Change-Id: Idae43a0162ee9bc687d21c550e0c9df33f12d263 Reviewed-on: https://cl.tvl.fyi/c/depot/+/11217 Tested-by: BuildkiteCI Reviewed-by: Connor Brewster --- tvix/castore/src/directoryservice/grpc.rs | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/tvix/castore/src/directoryservice/grpc.rs b/tvix/castore/src/directoryservice/grpc.rs index ad06cb17b6..fbb9cce64e 100644 --- a/tvix/castore/src/directoryservice/grpc.rs +++ b/tvix/castore/src/directoryservice/grpc.rs @@ -201,7 +201,9 @@ impl DirectoryService for GRPCDirectoryService { Ok(s) }); - Box::new(GRPCPutter::new(tx, task)) + Box::new(GRPCPutter { + rq: Some((task, tx)), + }) } } @@ -219,15 +221,6 @@ pub struct GRPCPutter { } impl GRPCPutter { - pub fn new( - directory_sender: UnboundedSender, - task: JoinHandle>, - ) -> Self { - Self { - rq: Some((task, directory_sender)), - } - } - // allows checking if the tx part of the channel is closed. // only used in the test case. #[cfg(test)] -- cgit 1.4.1