From b0bdeb2e895a4094247cf16fe41566b9f1b79f43 Mon Sep 17 00:00:00 2001 From: Connor Brewster Date: Sat, 20 Apr 2024 11:21:54 -0500 Subject: feat(tvix/castore): Fix build warnings in release mode Fixes some build warnings that only happen when building in release mode which disables `debug_assertions`. Change-Id: I554d5fce7c869c23cf4aa93179f0ee9f7f7c834e Reviewed-on: https://cl.tvl.fyi/c/depot/+/11490 Reviewed-by: raitobezarius Tested-by: BuildkiteCI Autosubmit: Connor Brewster Reviewed-by: flokli --- tvix/castore/src/directoryservice/closure_validator.rs | 1 + tvix/castore/src/import/mod.rs | 1 + 2 files changed, 2 insertions(+) diff --git a/tvix/castore/src/directoryservice/closure_validator.rs b/tvix/castore/src/directoryservice/closure_validator.rs index 461fc907bd..183928a86f 100644 --- a/tvix/castore/src/directoryservice/closure_validator.rs +++ b/tvix/castore/src/directoryservice/closure_validator.rs @@ -136,6 +136,7 @@ impl ClosureValidator { let mut visited_directory_count = 0; #[cfg(debug_assertions)] let mut visited_directory_ixs = HashSet::new(); + #[cfg_attr(not(debug_assertions), allow(unused))] while let Some(directory_ix) = traversal.next(&self.graph) { #[cfg(debug_assertions)] visited_directory_ixs.insert(directory_ix); diff --git a/tvix/castore/src/import/mod.rs b/tvix/castore/src/import/mod.rs index 72d55e13e0..7e60cf44d9 100644 --- a/tvix/castore/src/import/mod.rs +++ b/tvix/castore/src/import/mod.rs @@ -152,6 +152,7 @@ where // if there were directories uploaded, make sure we flush the putter, so // they're all persisted to the backend. if let Some(mut directory_putter) = maybe_directory_putter { + #[cfg_attr(not(debug_assertions), allow(unused))] let root_directory_digest = directory_putter.close().await?; #[cfg(debug_assertions)] -- cgit 1.4.1